Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display content of blog index or blog-section index #2073

Closed
wants to merge 2 commits into from

Conversation

froboy
Copy link
Contributor

@froboy froboy commented Aug 20, 2024

Fixes #1787.

I needed this for my project and saw the issue open. Currently Blog Section pages don't have a h1 either, so this adds the title of the section as well.

@froboy
Copy link
Contributor Author

froboy commented Aug 20, 2024

@chalin I took a quick stab at this. The content and title will be shown above Blog Sections.

From our site, as an example:

SCR-20240820-poxm

Copy link
Collaborator

@fekete-robert fekete-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@froboy
Copy link
Contributor Author

froboy commented Aug 21, 2024

Not quite... this displays the content on section pages, but duplicates it on blog items. Working on a fix.

@froboy
Copy link
Contributor Author

froboy commented Aug 21, 2024

{{ if .IsSection }} fixed that up.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @froboy.

After assessing alternatives, I think that it's better to add this feature via list.html instead. See:

@chalin
Copy link
Collaborator

chalin commented Jan 8, 2025

Closed in favor of:

@chalin chalin closed this Jan 8, 2025
@froboy froboy deleted the patch-1 branch January 8, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display content of blog index or blog-section index
3 participants